Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Whixp library to the list of softwares #1437

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

vsevex
Copy link
Contributor

@vsevex vsevex commented Sep 26, 2024

No description provided.

@guusdk
Copy link
Contributor

guusdk commented Sep 26, 2024

Thanks for this. As you may have noticed, the validation for this file is fairly strict. Your change is currently being rejected because of this:

ERROR: entry 'Whixp': should be placed in front of 'Z-XMPP' (all entries must be ordered alphabetically by case-folded name)

Can you please apply the desired change(s)?

@guusdk guusdk merged commit f4349a1 into xsf:master Sep 26, 2024
1 check passed
@cal0pteryx
Copy link
Member

@vsevex some changes are required for this to display correctly on xmpp.org

  1. DOAP file link: You're linking to a GitHub webpage, not the file itself. Please use a direct link ("Raw" button), like this: https://raw.githubusercontent.com/vsevex/whixp/refs/heads/main/doap.xml
  2. If a DOAP link is supplied, both platforms and url keys must be left empty. because those infos should be provided via DOAP file.

So in conclusion, your entry should look like this:

    {
      "categories": ["library"],
      "doap": "https://raw.githubusercontent.com/vsevex/whixp/refs/heads/main/doap.xml",
      "name": "Whixp",
      "platforms": [],
      "url": null
    },

@guusdk
Copy link
Contributor

guusdk commented Sep 26, 2024

Eek. Apologies for merging, I didn't know that.

Can we adjust the validation of PRs accordingly?

@cal0pteryx
Copy link
Member

No worries :) That's a good idea, I'll look into it.

@vsevex
Copy link
Contributor Author

vsevex commented Sep 26, 2024

Okay, I am opening a new PR now.

@cal0pteryx
Copy link
Member

Eek. Apologies for merging, I didn't know that.

Can we adjust the validation of PRs accordingly?

@guusdk a check has been implemented in b01dca1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants